[Randomness part 3] Remove math/rand from integration and insecure modules #4106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4106 +/- ##
==========================================
- Coverage 53.51% 50.87% -2.65%
==========================================
Files 833 600 -233
Lines 77896 55921 -21975
==========================================
- Hits 41687 28450 -13237
+ Misses 32874 25104 -7770
+ Partials 3335 2367 -968
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 235 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
tarakby
changed the title
peterargue
reviewed
Mar 29, 2023
integration/dkg/dkg_emulator_test.go
Outdated
| @@ -168,8 +168,6 @@ func (s *DKGSuite) runTest(goodNodes int, emulatorProblems bool) { | |||
|
|
|||
| // shuffle the signatures and indices before constructing the group | |||
| // signature (since it only uses the first half signatures) | |||
| seed := time.Now().UnixNano() | |||
There was a problem hiding this comment.
did you also want to update the import, or just remove the seed?
There was a problem hiding this comment.
time and rand are still used that's why the imports were not changed. Did I get your comment right?
| @@ -298,8 +298,6 @@ func TestWithWhiteboard(t *testing.T) { | |||
|
|
|||
| // shuffle the signatures and indices before constructing the group | |||
| // signature (since it only uses the first half signatures) | |||
| seed := time.Now().UnixNano() | |||
|
Closing as changes were incorporated in another PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
( result of splitting #4052 into several PRs)
math/randfunctionsSeedandRead.